Optimization: only run "git-rev-list HEAD" once.

statgit

@@ -73,46 +73,43 @@ class GitDataCollector(DataCollector):
 		self.activity_by_hour_of_day = {} # hour -> commits
 		self.activity_by_day_of_week = {} # day -> commits
 
-		# TODO
 		self.authors = {} # name -> {commits, first_commit_stamp, last_commit_stamp}
 
-		# activity
-		lines = getoutput('git-rev-list HEAD --pretty=format:%at |grep -v ^commit').split('\n')
-		for stamp in lines:
-			date = datetime.datetime.fromtimestamp(float(stamp))
-
-			# hour
-			hour = date.hour
-			if hour in self.activity_by_hour_of_day:
-				self.activity_by_hour_of_day[hour] += 1
-			else:
-				self.activity_by_hour_of_day[hour] = 1
-
-			# day
-			day = date.weekday()
-			if day in self.activity_by_day_of_week:
-				self.activity_by_day_of_week[day] += 1
-			else:
-				self.activity_by_day_of_week[day] = 1
-
-		# TODO author of the month
+		# author of the month
 		self.author_of_month = {} # month -> author -> commits
 		self.author_of_year = {} # year -> author -> commits
 		self.commits_by_month = {} # month -> commits
 		self.first_commit_stamp = 0
 		self.last_commit_stamp = 0
 
+		# TODO also collect statistics for "last 30 days"/"last 12 months"
 		lines = getoutput('git-rev-list --pretty=format:"%at %an" HEAD |grep -v ^commit').split('\n')
 		for line in lines:
 			parts = line.split(' ')
 			stamp = int(parts[0])
 			author = ' '.join(parts[1:])
+			date = datetime.datetime.fromtimestamp(float(stamp))
 
 			# First and last commit stamp
 			if self.last_commit_stamp == 0:
 				self.last_commit_stamp = stamp
 			self.first_commit_stamp = stamp
 
+			# activity
+			# hour
+			hour = date.hour
+			if hour in self.activity_by_hour_of_day:
+				self.activity_by_hour_of_day[hour] += 1
+			else:
+				self.activity_by_hour_of_day[hour] = 1
+
+			# day
+			day = date.weekday()
+			if day in self.activity_by_day_of_week:
+				self.activity_by_day_of_week[day] += 1
+			else:
+				self.activity_by_day_of_week[day] = 1
+
 			# author stats
 			if author not in self.authors:
 				self.authors[author] = {}